maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Picker ItemsSource fixes

Open BurningLights opened this issue 1 year ago • 7 comments

Description of Change

Fixes the Picker getting stuck in an infinite loop when the ItemsSource is assigned as an ObservableCollection and the collection is modified during a change handler when the SelectedIndex changes.

Issues Fixed

Fixes #19702

BurningLights avatar Jan 07 '24 00:01 BurningLights

Hey there @BurningLights! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Jan 07 '24 00:01 ghost

/azp run

jfversluis avatar Jan 08 '24 15:01 jfversluis

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 08 '24 15:01 azure-pipelines[bot]

Can you rebase on main please?

rmarinho avatar Jan 11 '24 20:01 rmarinho

@dotnet-policy-service agree

BurningLights avatar Jan 12 '24 00:01 BurningLights

/azp run

rmarinho avatar Jan 12 '24 12:01 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 12 '24 12:01 azure-pipelines[bot]

I am experiencing this too. Picker behave very weirdly when inside collection view.

SarthakB26 avatar Jan 14 '24 13:01 SarthakB26

/azp run

BurningLights avatar Feb 18 '24 17:02 BurningLights

Commenter does not have sufficient privileges for PR 19728 in repo dotnet/maui

azure-pipelines[bot] avatar Feb 18 '24 17:02 azure-pipelines[bot]

/azp run

PureWeen avatar Jun 02 '24 15:06 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 02 '24 15:06 azure-pipelines[bot]

/azp run

PureWeen avatar Jun 02 '24 16:06 PureWeen

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 02 '24 16:06 azure-pipelines[bot]

Looks fine to me! Maybe a UI test would be useful, but I can add it in this PR: https://github.com/dotnet/maui/pull/22353

kubaflo avatar Jun 02 '24 17:06 kubaflo