maui icon indicating copy to clipboard operation
maui copied to clipboard

Makes KeyboardAutoManager.GoToNextResponderOrResign public

Open rotorgames opened this issue 2 years ago • 9 comments

Description of Change

The PR changes access modifiers of the KeyboardAutoManager class and the GoToNextResponderOrResign method to public.

It helps implementing of custom text fields easily. As the GoToNextResponderOrResign method refers to a lot of other internal methods (that refer to other internal ones as well), it's challenging to just copy (or make own implementation) of that method. So, making this method public helps finding a next responder for iOS in custom text fields much easer.

Issues Fixed

Fixes #16949

rotorgames avatar Nov 10 '23 01:11 rotorgames

Hey there @rotorgames! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Nov 10 '23 01:11 ghost

cc @tj-devel709 thoughts?

jsuarezruiz avatar Nov 10 '23 11:11 jsuarezruiz

/azp run

rmarinho avatar Nov 14 '23 12:11 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 14 '23 12:11 azure-pipelines[bot]

Sorry, this one slipped my radar! I personally don't have a reason why it couldn't be public. @PureWeen, does that seem alright to you?

tj-devel709 avatar Dec 12 '23 21:12 tj-devel709

I think this is something we can make public! There will be a few more changes necessary that I will help out with, but as this is a new public API, this would be something for .NET 9!

tj-devel709 avatar Dec 12 '23 21:12 tj-devel709

+1 here

PavloLukianets avatar Dec 21 '23 10:12 PavloLukianets

/azp run

jsuarezruiz avatar Jan 12 '24 12:01 jsuarezruiz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 12 '24 12:01 azure-pipelines[bot]

this will need to target net9.0 for new api. please rebase and reopen .

Thanks

rmarinho avatar Feb 12 '24 15:02 rmarinho