maui icon indicating copy to clipboard operation
maui copied to clipboard

set the parents to installer

Open lewing opened this issue 2 years ago • 18 comments

This is updated dependencies against build ~~199238~~199405 of installer, It has runtime and emscripten switching to stable versions ~~but apparently not aspnetcore~~. You could definitely drop the separate variables for everything and do the substitution where they are used but hopefully this is enough to work with.

I updated the dependencies using darc update-dependencies --id 199405 feel free to pick a different installer build/bar id to use

lewing avatar Oct 17 '23 14:10 lewing

Hey there @lewing! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Oct 17 '23 14:10 ghost

Looks like duplicate https://github.com/dotnet/maui/pull/18085, maybe some parts are different.

trivalik avatar Oct 17 '23 17:10 trivalik

yeah, this was part of a discussion with rui, needs several changes I'll try to make later today

lewing avatar Oct 17 '23 20:10 lewing

This is updated dependencies against build 199238 of installer, It has runtime and emscripten switching to stable versions but apparently not aspnetcore. You could definitely drop the separate variables for everything and do the substitution where they are used but hopefully this is enough to work with.

I updated the dependencies using darc update-dependencies --id 199238 feel free to pick a different installer build/bar id/channel to use

lewing avatar Oct 28 '23 01:10 lewing

It would be nice if CI would run on my prs

lewing avatar Oct 28 '23 01:10 lewing

/azp run

rmarinho avatar Oct 28 '23 13:10 rmarinho

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '23 13:10 azure-pipelines[bot]

Deps have been updated to 199405 now

lewing avatar Oct 30 '23 17:10 lewing

/azp run

lewing avatar Oct 30 '23 17:10 lewing

Commenter does not have sufficient privileges for PR 18086 in repo dotnet/maui

azure-pipelines[bot] avatar Oct 30 '23 17:10 azure-pipelines[bot]

/azp run

steveisok avatar Oct 30 '23 20:10 steveisok

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 30 '23 20:10 azure-pipelines[bot]

/rebase

rmarinho avatar Oct 31 '23 10:10 rmarinho

Hmm

3d980e-1' of 'https://github.com/xamarin/xamarin-android')
Checking for coherency updates...
Using 'Strict' coherency mode. If this fails, a second attempt utilizing 'Legacy' Coherency mode will be made.
fail: Error: Failed to update dependencies.
      Microsoft.DotNet.DarcLib.DarcException: Dependency Microsoft.NETCore.App.Ref has non-existent parent dependency Microsoft.NET.Sdk.Internal
         at Microsoft.DotNet.DarcLib.Remote.GetRequiredStrictCoherencyUpdatesAsync(IEnumerable`1 dependencies, IRemoteFactory remoteFactory) in /_/src/Microsoft.DotNet.Darc/src/DarcLib/Actions/Remote.cs:line 526
         at Microsoft.DotNet.DarcLib.Remote.GetRequiredCoherencyUpdatesAsync(IEnumerable`1 dependencies, IRemoteFactory remoteFactory, CoherencyMode coherencyMode) in /_/src/Microsoft.DotNet.Darc/src/DarcLib/Actions/Remote.cs:line 1065
         at Microsoft.DotNet.Darc.Operations.UpdateDependenciesOperation.CoherencyUpdatesAsync(IRemote barOnlyRemote, IRemoteFactory remoteFactory, List`1 currentDependencies, List`1 dependenciesToUpdate) in /_/src/Microsoft.DotNet.Darc/src/Darc/Operations/UpdateDependenciesOperation.cs:line 316
         at Microsoft.DotNet.Darc.Operations.UpdateDependenciesOperation.ExecuteAsync() in /_/src/Microsoft.DotNet.Darc/src/Darc/Operations/UpdateDependenciesOperation.cs:line 204
PS C:\repos\dotnet\maui>

When I try to update using the channel I get this error.

rmarinho avatar Oct 31 '23 11:10 rmarinho

@lewing Could you rebase to fix the conflicts?. Thanks in advance!

jsuarezruiz avatar Nov 13 '23 16:11 jsuarezruiz

bad resolution, will fix tomorrow

lewing avatar Nov 16 '23 05:11 lewing

@rmarinho @Redth do we still want this or are alternate means working now?

lewing avatar Nov 30 '23 21:11 lewing

We still need to set it up better for net9. Can you try on that branch?

rmarinho avatar Dec 01 '23 14:12 rmarinho

@lewing can you rebase this on net9 for us to try there as net8 is old news?

rmarinho avatar Jan 22 '24 15:01 rmarinho

@lewing can you rebase this on net9 for us to try there as net8 is old news?

will update soonish

lewing avatar Jan 31 '24 01:01 lewing

Let's try this against the net9 branch , can you rebase and reopen when you have time @lewing ?

Thanks

rmarinho avatar Feb 16 '24 11:02 rmarinho