maui icon indicating copy to clipboard operation
maui copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[Windows] Fix Button LineBreakMode property

Open jsuarezruiz opened this issue 3 years ago • 3 comments

Description of Change

Fix Windows Button LineBreakMode property.

fix-button-padding

image

Issues Fixed

Fixes #9277 Fixes #10553

jsuarezruiz avatar Oct 18 '22 14:10 jsuarezruiz

@hartez I think you are working on big PR for all things line break and wrap... was that Android or everything? Will this conflict? Should we merge this and you are working on top?

mattleibow avatar Oct 18 '22 19:10 mattleibow

To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR require more work or event think in a better approach and for that reason is not included in the next release so I close it for now. I will reopen it and adapt to changes later.

jsuarezruiz avatar Nov 03 '22 08:11 jsuarezruiz

Is it possible to add tests for this? Maybe we can use the change in height to do something, or add some emoji with a color at the end and then when the ellipsis kicks in we can see that it is gone?

Sure thing. image

jsuarezruiz avatar Feb 10 '23 13:02 jsuarezruiz