fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

[FSharp.Editor] Tooltips are broken in project file but not in script file, and message shown twice.

Open smoothdeveloper opened this issue 2 years ago • 5 comments

This is what Visual Studio 2022 shows in a script:

image

This is what Visual Studio 2022 shows in a code file which is in a project: image

  • the format in project file is broken
  • in both cases, the same information is shown twice with no added information

smoothdeveloper avatar Nov 30 '23 07:11 smoothdeveloper

I think, it's technically not a bug, but a workaround of Roslyn bug when it wasn't displaying some errors during diagnostics and we had to duplicate them in other place.

https://github.com/dotnet/fsharp/pull/15982

@0101 we should probably revert it.

Thought might be something different of course.

vzarytovskii avatar Nov 30 '23 08:11 vzarytovskii

@smoothdeveloper in which version of VS are you seeing this?

0101 avatar Nov 30 '23 08:11 0101

Sorry I should have mentioned, 17.8.

The duplicate message has been around for a while AFAIR, and the carriage return in tooltips in projects, I can't really attest as I'll most often face it in a script or not spend too much time.

But it remains important to fix it IMO, the messages with carriage return stripped aren't more legible, even if the tooltip is going to take a lot of space.

smoothdeveloper avatar Nov 30 '23 09:11 smoothdeveloper

I don't see the doubling in 17.9, but the difference in formatting is there: image

image

majocha avatar Nov 30 '23 10:11 majocha

The formatting is not a tooltip issue:

image

majocha avatar Nov 30 '23 10:11 majocha