fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Wrong type is reported in type mismatch error

Open edgarfgp opened this issue 3 years ago • 3 comments

Fixes #13192 .

edgarfgp avatar Jun 22 '22 07:06 edgarfgp

@edgarfgp thanks for looking into this!

Would you mind adding "negtests" similar to those defined in this file https://github.com/dotnet/fsharp/blob/4be3bb5760e87ac522cd449c317016323f415467/tests/fsharp/tests.fs#L3374-L3405

Those test make sure the type checker error match desired output (that is error message with correct type mismatch info).

smoothdeveloper avatar Jun 22 '22 08:06 smoothdeveloper

Unfortunately I do not have the enough knowledge regarding error recovering to fix It is 50 % done IMO . Would be awesome if someone can take this one and finished it. I think would be a good improvement to have :) . Thanks @smoothdeveloper and @auduchinok for the pointers though .

edgarfgp avatar Jul 27 '22 13:07 edgarfgp

Gave this another go with @dsyme and I think it's now ready :)

0101 avatar Sep 22 '22 15:09 0101

@0101 This looks really good :) . Any thing pending to be ready for merge ?

edgarfgp avatar Oct 13 '22 11:10 edgarfgp

@edgarfgp I'd like to get @dsyme's review :) Or at minimum some other reviews...

0101 avatar Oct 13 '22 11:10 0101

Really good work!!! And so glad to see us making these core improvements

dsyme avatar Oct 17 '22 11:10 dsyme

@edgarfgp @0101 Yay! 🥳 🥳 🥳

dsyme avatar Oct 17 '22 17:10 dsyme

Thanks for making this happen . I have learn so much my reviewing this code :)

edgarfgp avatar Oct 17 '22 17:10 edgarfgp

@edgarfgp @dsyme optional continuation here: https://github.com/dotnet/fsharp/pull/14003 🙂

0101 avatar Oct 18 '22 09:10 0101