efcore icon indicating copy to clipboard operation
efcore copied to clipboard

Translate x.parse

Open MaRK0960 opened this issue 3 years ago • 3 comments
trafficstars

Fixes #28287

  • [x] I've read the guidelines for contributing and seen the walkthrough
  • [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [x] The code builds and tests pass locally (also verified by our automated build checks)
  • [x] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Code follows the same patterns and style as existing code in this repo

MaRK0960 avatar Jun 28 '22 18:06 MaRK0960

CLA assistant check
All CLA requirements met.

dnfadmin avatar Jun 28 '22 18:06 dnfadmin

Can we also get tests which converts from actual string values. Also some negative tests where the string is not exactly parse-able and we verify database behavior.

smitpatel avatar Jun 29 '22 19:06 smitpatel

@roji Is there anything else?

MaRK0960 avatar Aug 03 '22 19:08 MaRK0960

any updates on this @roji ?

tmricardo7 avatar Nov 17 '22 03:11 tmricardo7

@MaRK0960 sorry for not giving this any attention - the 7.0 release (and resulting bugfixes) are have taken up most of my time. I'll do my best to look at this again in the next couple of weeks.

roji avatar Nov 17 '22 08:11 roji

No problem, I will continue working on it.

MaRK0960 avatar Apr 25 '23 12:04 MaRK0960

@MaRK0960 ok great, let me know if you run out of time or something, otherwise you can ask for another review after you've made changes etc.

roji avatar Apr 25 '23 14:04 roji

@roji: ping

Saibamen avatar May 26 '23 07:05 Saibamen