efcore
efcore copied to clipboard
Translate x.parse
Fixes #28287
- [x] I've read the guidelines for contributing and seen the walkthrough
- [x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
- [x] The code builds and tests pass locally (also verified by our automated build checks)
- [x] Commit messages follow this format:
Summary of the changes
- Detail 1
- Detail 2
Fixes #bugnumber
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Code follows the same patterns and style as existing code in this repo
Can we also get tests which converts from actual string values. Also some negative tests where the string is not exactly parse-able and we verify database behavior.
@roji Is there anything else?
any updates on this @roji ?
@MaRK0960 sorry for not giving this any attention - the 7.0 release (and resulting bugfixes) are have taken up most of my time. I'll do my best to look at this again in the next couple of weeks.
No problem, I will continue working on it.
@MaRK0960 ok great, let me know if you run out of time or something, otherwise you can ask for another review after you've made changes etc.
@roji: ping