eShop
eShop copied to clipboard
dotnet
Add DSC Configuration to automate environment setup
Added a DSC configuration yaml and associated instructions to use DSC to setup a complete working dev environment. Yaml was added to a .configurations folder so that it can also be automatically detected by Dev Home and later Dev Box for automatic environment setup.
@adityamandaleeka FYI this adds a DevBox customization configuration to the eShop world...enabling eShop to be used as part of an included devbox image and have all the config needed to get it working on a new image. No eShop app code touched in this, think of this like a Codespaces config added value.
@timheuer & @adityamandaleeka. The configurations I added above will actually work on any windows development environment. They are only the DSC resources and powershell scripts. DSC is built into Windows.
Thanks for submitting this. I can see how this would be useful for some folks, but I feel it's a bit too aggressive in its current form and needs to be scoped down to just the minimum amount of things needed to work with eShop.
I'd also prefer to have the instructions show the manual steps first and then a "or, if you'd prefer, you can do this to have it set up for you". As a dev approaching the repo, it's useful to see what the setup process entails first, and this is especially true given that this is a sample and has educational value.
@adityamandaleeka , thanks for all the suggestions. I believe I resolved all your feedback.
@acangialosi hmm, I don't see the actual updates. Did you forget to push perhaps?
@acangialosi hmm, I don't see the actual updates. Did you forget to push perhaps?
Yes, apologies. I merged my changes from my working branch back into the PR.
Sorry for the long delays @acangialosi... it's been a really busy few weeks. This seems reasonable to me. I'm a little bit concerned about the instructions telling people to run things as Admin and with the -Force option, but I will leave that to @blowdart to comment on based on other places where we provide such instructions.
Approved tentatively, want to give @blowdart a chance to comment on the above.
Given that powershell can install extensions on a per user basis I'm confused about why admin privileges would be needed here. If it's just to reduce the number of elevation prompts during the winget restore then I'd remove the admin requirement and just let folks respond to each UAC prompt.
Given that powershell can install extensions on a per user basis I'm confused about why admin privileges would be needed here. If it's just to reduce the number of elevation prompts during the winget restore then I'd remove the admin requirement and just let folks respond to each UAC prompt.
The PSDscResources/WindowsOptionalFeature DSC resources need to run as admin and Winget won't UAC prompt when running a DSC configuration so the script just fails.