eShop
eShop copied to clipboard
dotnet
fix: init webhooksClient with launchProfile
Fix issue #298
Init the webhooksClient with specific profile.
@adityamandaleeka Can you help to give this an approval. I would say this can fix the issue #298. Thank you.
I am wondering whether it is necessary to specify the launch profile here or not. When Aspire launches a child service project, that service project "inherits" the launch profile that was used to launch Aspire itself. If there is not a matching launch profile then it'll use the first launch profile specified in launch settings.
You can achieve a lot by aligning the launch profiles between the AppHost and the service projects.
Wow, that's intereting. While as I tested on my machine, with Aspire preview5, it does not work to "inherits" the profile automatically for the project webhookclient...
@mitchdenny
As we can see in the dashboard, for those no launch profile configured project, they all run with http, while in fact I launch the eShop with http profile.
So, basically, maybe it's better to explicitly launch all projects with specific profile, by setting the specific profile when AddProject?
For the issue #298, since the profile mismatch for the CallbackUrl, the eShop launch fails.
I would argue its better to have your launch profiles aligned (in terms of their name) across app host and service projects.
OK...
Do you have any thoughts on the issues we are fixing? If we start the eShop with https profile, it should end up with passing the configuration to all the child projects. But seems something wrong. Can you repro it on your machine?
Can you still repro this issue? There was an issue with launch profiles that may have impacted you.
I can try it later. I have Aspire preview 5 on my machine. Should I upgrade to the latest version of Aspire?
I am also hitting this issue with Aspire 8.0.0-preview.6.24214.1/8.0.100. The fix applied here is the only way that I can successfully run HTTPS using macOS.
