aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

API proposal for NotFound related APIs

Open javiercn opened this issue 5 months ago • 1 comments

+Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs.NotFoundEventArgs(string! url) -> void +Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs.Path.get -> string! +Microsoft.AspNetCore.Components.Routing.IHostEnvironmentNavigationManager.Initialize(string! baseUri, string! uri, System.Func<string!, System.Threading.Tasks.Task!>! onNavigateTo) -> void +virtual Microsoft.AspNetCore.Components.RenderTree.Renderer.SignalRendererToFinishRendering() -> void +Microsoft.AspNetCore.Components.NavigationManager.OnNotFound -> System.EventHandler<Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs!>! +Microsoft.AspNetCore.Components.NavigationManager.NotFound() -> void +Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs +Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs.NotFoundEventArgs() -> void +++ b/src/Components/Components/src/PublicAPI.Unshipped.txt + +Microsoft.AspNetCore.Components.Routing.Router.NotFoundPage.get -> System.Type! +Microsoft.AspNetCore.Components.Routing.Router.NotFoundPage.set -> void +++ b/src/Middleware/Diagnostics/src/PublicAPI.Unshipped.txt +Microsoft.AspNetCore.Builder.StatusCodePagesOptions.CreateScopeForErrors.get -> bool +Microsoft.AspNetCore.Builder.StatusCodePagesOptions.CreateScopeForErrors.set -> void +static Microsoft.AspNetCore.Builder.StatusCodePagesExtensions.UseStatusCodePagesWithReExecute(this Microsoft.AspNetCore.Builder.IApplicationBuilder! app, string! pathFormat, bool createScopeForErrors, string? queryFormat = null) -> Microsoft.AspNetCore.Builder.IApplicationBuilder!

javiercn avatar Jun 17 '25 12:06 javiercn

Some of these APIs got already covered:

+Microsoft.AspNetCore.Components.NavigationManager.NotFound() -> void

in https://github.com/dotnet/aspnetcore/issues/61133 and as a result of that review, we added:

+Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs
+Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs.NotFoundEventArgs() -> void

in https://github.com/dotnet/aspnetcore/pull/61152.

+virtual Microsoft.AspNetCore.Components.RenderTree.Renderer.SignalRendererToFinishRendering() -> void

SignalRendererToFinishRendering is not public anymore, currently it's only internal. It was indeed added in public APIs in p4https://github.com/dotnet/aspnetcore/pull/61306 but was removed in p5 https://github.com/dotnet/aspnetcore/pull/61633 and since p6 it's internal only.

From this reason, I am skipping them in the new API review issues.

ilonatommy avatar Jun 19 '25 08:06 ilonatommy

Remaining API reviews from the list:

  • https://github.com/dotnet/aspnetcore/issues/62408
  • https://github.com/dotnet/aspnetcore/issues/62409
  • https://github.com/dotnet/aspnetcore/issues/62415
  • https://github.com/dotnet/aspnetcore/issues/62412

ilonatommy avatar Jun 19 '25 10:06 ilonatommy