aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

bumping ws dependency to fix component vulnerability

Open polatengin opened this issue 1 year ago • 2 comments

Bumping ws dependency to fix Component Vulnerability issue

ws package has a DoS attach vulnerability between v7.0.0 and v7.5.10

Details can be found here; https://security.snyk.io/package/npm/ws

GitHub Code Scanning feature shows a High Severity alert

Description

ws dependency in the package.json is pinned to v7.4.5, and it needs to be updated to at least v7.5.10

Fixes #56723

polatengin avatar Aug 26 '24 21:08 polatengin

Thanks for doing this, I'm experiencing this issue at my org - much needed!

Marcusg62 avatar Aug 26 '24 23:08 Marcusg62

Also experiencing this issue at my org - really appreciate the PR!

jamesdten avatar Aug 27 '24 12:08 jamesdten

Thanks for the change!

wtgodbe avatar Aug 30 '24 16:08 wtgodbe

When will this make it into a version of @microsoft/signalr on npm? Looks like the latest version available there contains the impacted version of ws: https://www.npmjs.com/package/@microsoft/signalr?activeTab=code

Thanks!

timminss avatar Oct 16 '24 14:10 timminss

This change was made in our 10.0 branch, which we're not shipping until next year. I can backport it to 9.0 and 8.0 so that it makes it into our next monthly release - unfortunately the branches are closed right now, so the fix won't ship until December.

wtgodbe avatar Oct 16 '24 16:10 wtgodbe

/backport to release/9.0

wtgodbe avatar Oct 16 '24 16:10 wtgodbe

/backport to release/8.0

wtgodbe avatar Oct 16 '24 16:10 wtgodbe

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/11369683658

github-actions[bot] avatar Oct 16 '24 16:10 github-actions[bot]

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/11369685243

github-actions[bot] avatar Oct 16 '24 16:10 github-actions[bot]

Actually, I was able to get this merged in time for the 9.0.0 RTM release in November

wtgodbe avatar Oct 16 '24 23:10 wtgodbe

When will you publish this fix? For the latest 8.0.7, it still uses "ws": "^7.4.5"

neoskx avatar Jan 17 '25 23:01 neoskx

When will you publish this fix? For the latest 8.0.7, it still uses "ws": "^7.4.5"

Which package are you referring to? The 8.0 SignalR package has been using 7.5.10 for some time now:

https://github.com/dotnet/aspnetcore/blob/db9f8d7a5aa19a582dcec04c7ae6f5d4bd2df422/src/SignalR/clients/ts/signalr/package.json#L58

wtgodbe avatar Jan 17 '25 23:01 wtgodbe

npm package still contain "ws": "^7.4.5" https://www.npmjs.com/package/@microsoft/signalr?activeTab=code

sochetanie avatar Jan 21 '25 16:01 sochetanie