aspnetcore
aspnetcore copied to clipboard
consider escaped commas in LDAP distinguished name
Consider escaped commas in LDAP distinguished name
Description
In real world DN can be like this: CN=Testing group**\,**City,OU=Department,DC=contoso,DC=com. We need to process this case correct - consider escaped comma and don't fail.
Without this fix DN parsing is incorrect -> we getting Testing group\ as CN instead of Testing group. Next, we try to resolve group with incorrect CN and getting exception.
Fixes #45648
Thanks for your PR, @teh13th. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.
@HaoK, @Tratcher can you look this, please?
Can you add some unit tests?
@HaoK, @Tratcher can you look this, please?
Also, people are still on vacation so expect slow responses until next week.
Some checks haven’t completed yet
Done.
@Tratcher, @danmoseley, @joperezr, @HaoK ping :)
Thanks for the fix @teh13th! I'm just triggering a rerun of the build and marking this as auto merge once that passes.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).
@HaoK something gone wrong.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).