aspnetcore icon indicating copy to clipboard operation
aspnetcore copied to clipboard

consider escaped commas in LDAP distinguished name

Open teh13th opened this issue 2 years ago • 4 comments

Consider escaped commas in LDAP distinguished name

Description

In real world DN can be like this: CN=Testing group**\,**City,OU=Department,DC=contoso,DC=com. We need to process this case correct - consider escaped comma and don't fail. Without this fix DN parsing is incorrect -> we getting Testing group\ as CN instead of Testing group. Next, we try to resolve group with incorrect CN and getting exception.

Fixes #45648

teh13th avatar Dec 17 '22 17:12 teh13th

Thanks for your PR, @teh13th. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ghost avatar Dec 17 '22 17:12 ghost

@HaoK, @Tratcher can you look this, please?

teh13th avatar Dec 28 '22 14:12 teh13th

Can you add some unit tests?

davidfowl avatar Dec 28 '22 16:12 davidfowl

@HaoK, @Tratcher can you look this, please?

Also, people are still on vacation so expect slow responses until next week.

davidfowl avatar Dec 28 '22 16:12 davidfowl

CLA assistant check
All CLA requirements met.

dnfadmin avatar Jan 14 '23 13:01 dnfadmin

Some checks haven’t completed yet

Done.

teh13th avatar Jan 14 '23 15:01 teh13th

@Tratcher, @danmoseley, @joperezr, @HaoK ping :)

teh13th avatar Jan 18 '23 13:01 teh13th

Thanks for the fix @teh13th! I'm just triggering a rerun of the build and marking this as auto merge once that passes.

HaoK avatar Jan 25 '23 06:01 HaoK

/azp run

HaoK avatar Jan 25 '23 06:01 HaoK

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 25 '23 06:01 azure-pipelines[bot]

@HaoK something gone wrong.

teh13th avatar Jan 25 '23 16:01 teh13th

/azp run

adityamandaleeka avatar Jan 26 '23 00:01 adityamandaleeka

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jan 26 '23 00:01 azure-pipelines[bot]