aspnet-api-versioning icon indicating copy to clipboard operation
aspnet-api-versioning copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Add support for odata v9

Open arabelaa opened this issue 1 year ago • 5 comments
trafficstars

Add support for Microsoft.AspNetCore.OData v9

  • [ ] You've read the Contributor Guide and Code of Conduct.
  • [ ] You've included unit or integration tests for your change, where applicable.
  • [ ] You've included inline docs for your change, where applicable.
  • [x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Issue ref: https://github.com/dotnet/aspnet-api-versioning/issues/1103

With the release of Microsoft.AspNetCore.OData 9 https://devblogs.microsoft.com/odata/announcing-asp-net-core-odata-9-official-release/, I thought it's time to have support in aspnet-api-versioning.

  • Bump version to 9.0.0 to be inline with AspNetCore.OData 9
  • Introduced CS0618 warnings because of 2 obsolete methods
    • https://github.com/OData/odata.net/blob/8.0.1/src/Microsoft.OData.Edm/ExtensionMethods/ExtensionMethods.cs#L2885
    • https://github.com/OData/AspNetCoreOData/blob/9.0.0/src/Microsoft.AspNetCore.OData/ODataOptions.cs#L293

arabelaa avatar Sep 02 '24 10:09 arabelaa

@dotnet-policy-service agree company="UiPath"

arabelaa avatar Sep 02 '24 10:09 arabelaa

@commonsensesoftware can you please have a look?

arabelaa avatar Sep 02 '24 11:09 arabelaa

Can someone review and merge please ?

We'd like to be able to use odata v9 with api versioning

ct-jby avatar Oct 06 '24 16:10 ct-jby

Can someone please merge this PR

mike-bagheri avatar Oct 08 '24 02:10 mike-bagheri

Apologies for the delay. I've been a bit backed up by my day job and personal life of late. To be clear, I am the someone to review and merge the change. This entire repo from code to docs is managed by a single person - me (and always has been).

I appreciate the urgency and ❤️ that someone has put forth the effort to create a PR. Honestly, that's pretty infrequent in this repo. I need to spend some time to consider the full impact; especially, since this PR intends to bump the major version. .NET 9 is just around the corner and I'd prefer that all the major version numbers line up, even though I realize OData doesn't release on the standard cadence. If OData was more stable, I'd leave the major version open, which may have negated this change; however, I've been bitten by its breaking changes countless times.

You're not being ignored. Releases need to be of the highest quality. My mental plan of action is as follows:

  • Determine if this change can be multi-targeted to stay within the 8.x version
  • If not, consider a stable 9.0-preview so 9.0 can release consistently across the board

I'll do what I can to carve out some time over the next days to flush things out get this change rolling forward. Thanks for your patience.

commonsensesoftware avatar Oct 08 '24 03:10 commonsensesoftware

Net9 is here. When version to support Net 9. Thanks.

jvsancho80 avatar Nov 15 '24 14:11 jvsancho80

Any news :) ?

ct-jby avatar Dec 06 '24 08:12 ct-jby

Any news in 2025? :)

soshman avatar Jan 08 '25 15:01 soshman

News??

ljsomm avatar Apr 08 '25 21:04 ljsomm

@commonsensesoftware OData 9 still depends on .net 8 so we probably should not change the major version of API versioning. https://www.nuget.org/packages/Microsoft.AspNetCore.OData

xavierjohn avatar Apr 11 '25 16:04 xavierjohn

This work is done in PR 1129

xavierjohn avatar Apr 22 '25 19:04 xavierjohn