aspnet-api-versioning icon indicating copy to clipboard operation
aspnet-api-versioning copied to clipboard

fix(ApiExplorer): SubstitutedType have invalid property setter

Open AndreaCuneo opened this issue 1 year ago • 2 comments
trafficstars

fix(ApiExplorer): SubstitutedType have invalid property setter

  • [x] You've read the Contributor Guide and Code of Conduct.
  • [x] You've included unit or integration tests for your change, where applicable.
  • [x] You've included inline docs for your change, where applicable.
  • [x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

The PropertySetter of the SubstitutedType properties have 0 parameters: they had the same signature of the Getter.

Fixes #1104

AndreaCuneo avatar Aug 28 '24 08:08 AndreaCuneo

@dotnet-policy-service agree

AndreaCuneo avatar Aug 28 '24 08:08 AndreaCuneo

@commonsensesoftware can you please take a look. is a 1 line change plus tests.

AndreaCuneo avatar Sep 03 '24 15:09 AndreaCuneo

This works! I implemented the fix and published a new package version to our internal feeds, and now we can upgrade our odata projects to at least Swashbuckle 9. @AndreaCuneo thanks a million! Hopefully this gets merged to mainline soon

spaasis avatar Nov 12 '25 08:11 spaasis