aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Docs to cover 6006.

Open mitchdenny opened this issue 1 year ago • 5 comments

Description

Adding some remarks to WithEndpoint(callback) to explain why setting protocol doesn't update urischeme automatically.

Fixes #6006

Checklist

  • Is this feature complete?
    • [x] Yes. Ready to ship.
    • [ ] No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • [ ] Yes
    • [x] No
  • Did you add public API?
    • [ ] Yes
      • If yes, did you have an API Review for it?
        • [ ] Yes
        • [ ] No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • [ ] Yes
        • [ ] No
    • [x] No
  • Does the change make any security assumptions or guarantees?
    • [ ] Yes
      • If yes, have you done a threat model and had a security review?
        • [ ] Yes
        • [ ] No
    • [x] No
  • Does the change require an update in our Aspire docs?
    • [ ] Yes
      • Link to aspire-docs issue:
    • [x] No
Microsoft Reviewers: Open in CodeFlow

mitchdenny avatar Oct 04 '24 04:10 mitchdenny

/azp run

mitchdenny avatar Oct 04 '24 12:10 mitchdenny

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 04 '24 12:10 azure-pipelines[bot]

It should update the scheme.

davidfowl avatar Oct 04 '24 14:10 davidfowl

That would make it order dependent.

mitchdenny avatar Oct 04 '24 23:10 mitchdenny

We should set the scheme when you set the protocol (in the property setter). We do the same wtih port and target port (if target port is unset)

davidfowl avatar Oct 04 '24 23:10 davidfowl