aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Fix template warnings during build

Open sebastienros opened this issue 1 year ago • 10 comments

Fixes #2893

Checking the JSON schema and the templates doc these properties seem to be required in the files.

Microsoft Reviewers: Open in CodeFlow

sebastienros avatar Sep 07 '24 00:09 sebastienros

I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?

DamianEdwards avatar Sep 08 '24 17:09 DamianEdwards

/azp run

davidfowl avatar Sep 09 '24 00:09 davidfowl

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 09 '24 00:09 azure-pipelines[bot]

/azp run

radical avatar Sep 10 '24 06:09 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 10 '24 06:09 azure-pipelines[bot]

I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?

I'm not sure about the warnings either, what was getting warnings? The lack of entries in the localization files? @joeloff I'm not sure how the loc infrastructure works here, is it necessary to seed all the non-enu files, or should only the en-us be modified with the text from the template.json?

phenning avatar Sep 11 '24 13:09 phenning

I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?

I'm not sure about the warnings either, what was getting warnings? The lack of entries in the localization files? @joeloff I'm not sure how the loc infrastructure works here, is it necessary to seed all the non-enu files, or should only the en-us be modified with the text from the template.json?

Don't think it needs to have it, but the localization infrastructure often copies new ENU values for all the locales and then vendors would eventually pick those up for translation

joeloff avatar Sep 11 '24 14:09 joeloff

/azp run

radical avatar Sep 11 '24 19:09 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 19:09 azure-pipelines[bot]

Added documentation on how localization works (there is a bot) so we just need to provide the english entries as the source.

@phenning the warnings are as such

.../Microsoft.TemplateEngine.Authoring.Tasks.targets(17,5): Template configuration message MV008: Missing 'generatorVersions'. [/Users/ankj/dev/aspire/src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj]
.../Microsoft.TemplateEngine.Authoring.Tasks.targets(17,5): Template configuration message MV011: One or more postActions have a malformed or missing manualInstructions value. [/Users/ankj/dev/aspire/src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj]

sebastienros avatar Oct 02 '24 18:10 sebastienros

Stale

davidfowl avatar Jan 14 '25 08:01 davidfowl

This submission has been automatically marked as stale because it has been marked as requiring author action but has not had any activity for 14 days. It will be closed if no further activity occurs within 7 days of this comment.