aspire
aspire copied to clipboard
Fix template warnings during build
Fixes #2893
Checking the JSON schema and the templates doc these properties seem to be required in the files.
Microsoft Reviewers: Open in CodeFlow
I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?
I'm not sure about the warnings either, what was getting warnings? The lack of entries in the localization files? @joeloff I'm not sure how the loc infrastructure works here, is it necessary to seed all the non-enu files, or should only the en-us be modified with the text from the template.json?
I don't know anything about the warnings this fixes I'm sorry. @phenning @sayedihashimi can you review this change please?
I'm not sure about the warnings either, what was getting warnings? The lack of entries in the localization files? @joeloff I'm not sure how the loc infrastructure works here, is it necessary to seed all the non-enu files, or should only the en-us be modified with the text from the template.json?
Don't think it needs to have it, but the localization infrastructure often copies new ENU values for all the locales and then vendors would eventually pick those up for translation
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Added documentation on how localization works (there is a bot) so we just need to provide the english entries as the source.
@phenning the warnings are as such
.../Microsoft.TemplateEngine.Authoring.Tasks.targets(17,5): Template configuration message MV008: Missing 'generatorVersions'. [/Users/ankj/dev/aspire/src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj]
.../Microsoft.TemplateEngine.Authoring.Tasks.targets(17,5): Template configuration message MV011: One or more postActions have a malformed or missing manualInstructions value. [/Users/ankj/dev/aspire/src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj]
Stale
This submission has been automatically marked as stale because it has been marked as requiring author action but has not had any activity for 14 days. It will be closed if no further activity occurs within 7 days of this comment.