aspire icon indicating copy to clipboard operation
aspire copied to clipboard

Add `WithPgWeb`

Open Alirexaa opened this issue 1 year ago • 4 comments
trafficstars

close: #3081

Microsoft Reviewers: Open in CodeFlow

Alirexaa avatar Jul 28 '24 20:07 Alirexaa

@Alirexaa this is looking pretty good. A few minor things. We'll need a docs issue/PR filed for this as well (probably just updating the existing doc page for Postgres).

mitchdenny avatar Jul 29 '24 04:07 mitchdenny

@mitchdenny besides these things, this PR needs more work to do, right now bookmarks populate in pgweb but when selecting one of those to connect, connection refuse occur. Also need to write some tests

Alirexaa avatar Jul 29 '24 05:07 Alirexaa

To pass all tests we need to import docker.io/sosedoff/pgweb/latest to netaspireci.azurecr.io

Alirexaa avatar Aug 08 '24 19:08 Alirexaa

@eerhardt could you please import docker.io/sosedoff/pgweb/latest to make ci green?

Alirexaa avatar Aug 09 '24 18:08 Alirexaa

Can you please add some information in PR description, maybe even just links to pgweb?

radical avatar Aug 15 '24 20:08 radical

@eerhardt could you please import docker.io/sosedoff/pgweb/latest to make ci green?

I've pushed it to the netaspireci.azurecr.io registry. However, I don't believe the test will pass because the CI machines don't have Docker Desktop installed, which means there isn't network communication between the containers.

eerhardt avatar Aug 16 '24 15:08 eerhardt

@eerhardt could you please import docker.io/sosedoff/pgweb/latest to make ci green?

I've pushed it to the netaspireci.azurecr.io registry. However, I don't believe the test will pass because the CI machines don't have Docker Desktop installed, which means there isn't network communication between the containers.

What can I do for that?

Alirexaa avatar Aug 16 '24 16:08 Alirexaa

What can I do for that?

For now we've been disabling the test in CI until the problem can be resolved.

eerhardt avatar Aug 16 '24 18:08 eerhardt

/azp run

radical avatar Aug 16 '24 18:08 radical

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 16 '24 18:08 azure-pipelines[bot]