aspire
aspire copied to clipboard
Adding WebPubSub component and provisioning
There's a big split coming here https://github.com/dotnet/aspire/pull/3062
cc @mitchdenny
The split is merged so this PR will need to react to that @vicancy
Waiting for this https://github.com/Azure/azure-sdk-for-net/pull/43027 to be integrated into Azure.Provisioning
This is looking pretty good. General feedback is about making sure you put some good examples in the /// docs just to make it easy for folks.
One more thing. What is the story here around the .NET client side of this experience? If someone wants to use WebPubSub in a S2S scenario, do we want any observability from WebPubSubClient to the service?
Hi @mitchdenny I changed to always use hubName as the serviceKey, please check if you have any concerns about the change.
For the websocket WebPubSubClient working in S2S scenario, it is a really good question, and it is indeed a valid scenario, but I'd prefer hold adding it into Aspire to avoid confusions on too many components in WebPubSub for now until we have a good story/definition/good-practices for the S2S scenario using WebPubSubClient.
@eerhardt wanted to get your input here around the keyed DI injection of the client where you might have a single webpubsub resource but multiple hubs. Should we be providing the option for people to specify the connection string name, hub name AND the key that is used?