aspire icon indicating copy to clipboard operation
aspire copied to clipboard

[release/13.0] Filter to highest package version per channel in aspire add command

Open github-actions[bot] opened this issue 1 month ago • 5 comments

Backport of #12553 to release/13.0

/cc @mitchdenny @Copilot

Customer Impact

This PR addresses an issue in the aspire add command where we show two versions of a package when a channel is chosen when only one should be shown. The underlying reason is that a channel is often comprised of multiple feeds (e.g. the daily feed references dotnet9 and nuget.org) and in the case of the Docker integration there is a pre-release package in both.

This update effectively filters the list so we only show the highest version across package sources.

Before:

image

After:

image

Testing

Manual validation

Risk

Low. Mostly impacts the preview PR experience (or when using a preview package)

Regression?

github-actions[bot] avatar Nov 01 '25 05:11 github-actions[bot]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12587

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12587"

github-actions[bot] avatar Nov 01 '25 05:11 github-actions[bot]

Low risk and contained to the specific command. Marking as approved, but I also think that if we think this may impact other things we can also hold off for 13.1

joperezr avatar Nov 03 '25 21:11 joperezr

Agree

davidfowl avatar Nov 04 '25 05:11 davidfowl

@mitchdenny any final thoughts here? if we feel good about low risk of potential side effects I can go ahead and merge this.

joperezr avatar Nov 06 '25 01:11 joperezr

Removing approval for now since at this point we should just wait for 13.0.1

joperezr avatar Nov 07 '25 21:11 joperezr

@mitchdenny do we still want this one for 13.0.1?

joperezr avatar Nov 24 '25 18:11 joperezr

Yep

mitchdenny avatar Nov 24 '25 20:11 mitchdenny