arcade
arcade copied to clipboard
Arcade doesn't run .NET Framework tests in CI
... is that intentional?
cc @mmitche @chcosta @riarenas
Ricardo / Chris can you please let us know if this is intentional? If not, we should fix that as people currently assume that .NET Framework test projects are run.
@ViktorHofer are there specific tests you want to be ran?
All of the test projects in this repo that target .NET Framework.
@mmitche ^
I don't know the reason. I think it has always been like this, actually. At least since the move to Helix.
The original commit of the UnitTests.proj is from early 2019: https://github.com/dotnet/arcade/commit/3f3547b57c504f52c9459091e09b4703536e44c0
This commit later on adds some VS specific tasks that don't target netcore at all and the tests are excluded there on purpose. This suggest to me that they weren't running when https://github.com/dotnet/arcade/pull/1966 was created.
@ViktorHofer what do you think are the next steps here?
Either delete all .NET Framework test projects from Arcade and accept and document that .NET Framework assets are completely untested or bring infrastructure in/back to run .NET Framework tests.
Triage: whoever takes this issue should:
- is it feasible to turn on the Framework tests?
- if not, document that the tests aren't running.