arcade icon indicating copy to clipboard operation
arcade copied to clipboard

Arcade doesn't run .NET Framework tests in CI

Open ViktorHofer opened this issue 2 years ago • 8 comments

... is that intentional?

cc @mmitche @chcosta @riarenas

ViktorHofer avatar Oct 16 '23 18:10 ViktorHofer

Ricardo / Chris can you please let us know if this is intentional? If not, we should fix that as people currently assume that .NET Framework test projects are run.

ViktorHofer avatar Nov 06 '23 17:11 ViktorHofer

@ViktorHofer are there specific tests you want to be ran?

missymessa avatar Nov 15 '23 21:11 missymessa

All of the test projects in this repo that target .NET Framework.

ViktorHofer avatar Nov 16 '23 09:11 ViktorHofer

@mmitche ^

missymessa avatar Nov 16 '23 21:11 missymessa

I don't know the reason. I think it has always been like this, actually. At least since the move to Helix.

The original commit of the UnitTests.proj is from early 2019: https://github.com/dotnet/arcade/commit/3f3547b57c504f52c9459091e09b4703536e44c0

This commit later on adds some VS specific tasks that don't target netcore at all and the tests are excluded there on purpose. This suggest to me that they weren't running when https://github.com/dotnet/arcade/pull/1966 was created.

mmitche avatar Nov 16 '23 21:11 mmitche

@ViktorHofer what do you think are the next steps here?

missymessa avatar Nov 30 '23 21:11 missymessa

Either delete all .NET Framework test projects from Arcade and accept and document that .NET Framework assets are completely untested or bring infrastructure in/back to run .NET Framework tests.

ViktorHofer avatar Dec 01 '23 12:12 ViktorHofer

Triage: whoever takes this issue should:

  • is it feasible to turn on the Framework tests?
  • if not, document that the tests aren't running.

missymessa avatar Jan 11 '24 21:01 missymessa