Open-XML-SDK icon indicating copy to clipboard operation
Open-XML-SDK copied to clipboard

removal of pictureOptions and bubble3D properties from five complext …

Open tomjebo opened this issue 9 months ago • 6 comments

…types for v4 per #1769

tomjebo avatar Mar 21 '25 15:03 tomjebo

TODO:

  • [ ] remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

tomjebo avatar Mar 21 '25 15:03 tomjebo

Test Results

    55 files   -   4      55 suites   - 4   52m 0s ⏱️ -29s  2 041 tests ±  0   2 038 ✅ ±  0   3 💤 ±0  0 ❌ ±0  31 933 runs   - 234  31 897 ✅  - 234  36 💤 ±0  0 ❌ ±0 

Results for commit e0eb6a4f. ± Comparison against base commit d5963544.

github-actions[bot] avatar Mar 21 '25 15:03 github-actions[bot]

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

mikeebowen avatar Mar 21 '25 16:03 mikeebowen

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

after #1905 merges to main, I'll add the code to this PR to remove the obsolete attribute entries. @mikeebowen I've changed this PR to draft and added a todo task to remove the attribute entries.

tomjebo avatar Mar 21 '25 18:03 tomjebo

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

I labeled it with v4.0 milestone initially. The original issue https://github.com/dotnet/Open-XML-SDK/issues/1769 I closed. I don't think we need a new issue.

tomjebo avatar Mar 21 '25 18:03 tomjebo

Isn't this a breaking change? Should we create a v4 branch and merge it into that?

I can also do this if we decide that's the way to go. But it will have to wait until the PR is no longer draft.

tomjebo avatar Mar 21 '25 18:03 tomjebo