removal of pictureOptions and bubble3D properties from five complext …
…types for v4 per #1769
TODO:
- [ ] remove the
_attributeDataentries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs
Test Results
55 files - 4 55 suites - 4 52m 0s ⏱️ -29s 2 041 tests ± 0 2 038 ✅ ± 0 3 💤 ±0 0 ❌ ±0 31 933 runs - 234 31 897 ✅ - 234 36 💤 ±0 0 ❌ ±0
Results for commit e0eb6a4f. ± Comparison against base commit d5963544.
reminder: before merging this for v4.0 , remove the
_attributeDataentries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs
We should make an issue for this and add it to the v4 milestone
reminder: before merging this for v4.0 , remove the
_attributeDataentries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.csWe should make an issue for this and add it to the v4 milestone
after #1905 merges to main, I'll add the code to this PR to remove the obsolete attribute entries. @mikeebowen I've changed this PR to draft and added a todo task to remove the attribute entries.
reminder: before merging this for v4.0 , remove the
_attributeDataentries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.csWe should make an issue for this and add it to the v4 milestone
I labeled it with v4.0 milestone initially. The original issue https://github.com/dotnet/Open-XML-SDK/issues/1769 I closed. I don't think we need a new issue.
Isn't this a breaking change? Should we create a v4 branch and merge it into that?
I can also do this if we decide that's the way to go. But it will have to wait until the PR is no longer draft.