"SDL 7.0" code analysis ruleset is not in repo

[Porges]

trafficstars

Can this be added? At the moment CA just fails due to it not existing.

[mike-barnett]

Doesn't that just come with Visual Studio? I don't recall installing it myself. Let me know!

Mike

[Porges]

I think on MS computers it is installed automatically with all the other SDL tooling. A quick search shows the AzureAD team also added theirs to their repo: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/pull/151

[mike-barnett]

Okay. Let me check with the necessary authorities...

[jnm2]

When you open the solution in VS2017 RTM, you are presented with this:

Code	Description
	Could not find rule set file "Sdl7.0.ruleset".
	Could not find rule set file "Sdl7.0.ruleset".
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.AssemblyResolver()'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.AssemblyResolver(string)'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.AssemblyResolver(IDictionary)'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.AssemblyCache'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.SearchDirectories'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.InputDirectory'
CS1591	Missing XML comment for publicly visible type or member 'AssemblyResolver.Resolve(AssemblyReference, Module)'
CA0064	CA0064 : No analysis was performed because the specified rule set could not be loaded or did not contain any managed code analysis rules.
CA0063	CA0063 : * Failed to load rule set file 'Sdl7.0.ruleset' or one of its dependent rule set files.
CA0064	CA0064 : No analysis was performed because the specified rule set could not be loaded or did not contain any managed code analysis rules.
CA0063	CA0063 : * Failed to load rule set file 'Sdl7.0.ruleset' or one of its dependent rule set files.

Might be nice to suppress in the csproj any warnings that don't matter and fix those that do.