EntityFramework.ApiDocs icon indicating copy to clipboard operation
EntityFramework.ApiDocs copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Fix breadcrumbs

Open raprice opened this issue 1 year ago • 6 comments

This PR brings breadcrumb implementation into alignment with platform architecture requirements. This PR is part of a previously announced batch of breadcrumb fixes across the Learn platform and will be auto-merged if there are no build warnings. This PR may include removing the “extend breadcrumb” feature from any docfx files that are still using it, fixing breadcrumb file references in the docfx file, and rewriting breadcrumb files to match the approved breadcrumb pattern for a given product’s documentation.

raprice avatar Dec 12 '23 20:12 raprice

@raprice can you mark this ready for review? image @gewarren is this change OK to API?

Rick-Anderson avatar Jan 24 '24 04:01 Rick-Anderson

@Rick-Anderson @gewarren Please review, thanks!

raprice avatar Mar 01 '24 17:03 raprice

@raprice I'm not sure that this is working how you want it to work. For example compare these two pages:

  • https://review.learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore?view=efcore-8.0&branch=pr-en-us-136 (this PR)
  • https://learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore?view=efcore-8.0 (live)

gewarren avatar Mar 01 '24 19:03 gewarren

@gewarren You're absolutely right, something is funky. I will dig into this, putting back in draft until I get this rendering correctly. Thanks for catching it!

raprice avatar Mar 01 '24 20:03 raprice

dotnet/entityframework.apidocs

Srbo0 avatar Mar 02 '24 21:03 Srbo0

@gewarren Please take a look - the breadcrumbs from this PR are now rendering correctly (Learn / .NET / Entity Framework / .NET API browser) https://review.learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore?view=efcore-8.0&branch=pr-en-us-136

raprice avatar Mar 04 '24 20:03 raprice