AspNetCore.Docs icon indicating copy to clipboard operation
AspNetCore.Docs copied to clipboard

fix(health-checks): cors origin doesn't accept empty args

Open timdeschryver opened this issue 3 years ago • 1 comments

This PR doesn't resolve an issue, but it addresses a small mistake in the docs. As shown in the image below, RequireCors requires us to pass a builder, or a policy name. The method gives a compile error when no arguments are provided, but the docs mention that it should be possible.

image

Link to the source code with the allowed signatures.

timdeschryver avatar Aug 10 '22 18:08 timdeschryver

@FirstAfterGod2501 please review

Rick-Anderson avatar Aug 10 '22 23:08 Rick-Anderson

@timdeschryver thanks for your contribution. Be sure to check out your name as a contributor about the 3rd of next month on the What's new page in the Community contributors section at the bottom.

Rick-Anderson avatar Aug 13 '22 01:08 Rick-Anderson

Cool, thanks @Rick-Anderson !

timdeschryver avatar Aug 13 '22 10:08 timdeschryver