AspNetCore.Docs icon indicating copy to clipboard operation
AspNetCore.Docs copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

What's new for gRPC and SignalR in ASP.NET Core 7.0

Open Rick-Anderson opened this issue 3 years ago • 13 comments

@wadepickett this is the gRPC and Signal version of what's new for .NET 7 issue tracking.:

  • Create issues for each item in the preview blogs that's tied to the gRPC or Signal doc.
  • After you update a gRPC or Signal doc, update What's new in ASP.NET Core 7.0. You need to do a fast update, checked out no more that 2 hours because @guardrex and I are making frequent updates to that doc.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Rick-Anderson avatar Jul 20 '22 01:07 Rick-Anderson

@Rick-Anderson, thanks. Please see your calendar. I will not be able to be on this until after the 28th.

wadepickett avatar Jul 22 '22 04:07 wadepickett

@Rick-Anderson, do you mean pull all gRPC and SignalR info from previews 1-6 blogs (combining and updating where needed) and putting them into the What's new in ASP.NET Core 7.0 with the information? Do I understand correctly? (I do understand the part about getting in and out of the final What's new quickly.) Thanks for the help.

wadepickett avatar Aug 03 '22 02:08 wadepickett

@Rick-Anderson, do you mean pull all gRPC and SignalR info from previews 1-6 blogs (combining and updating where needed) and putting them into the What's new in ASP.NET Core 7.0 with the information? Do I understand correctly? (I do understand the part about getting in and out of the final What's new quickly.) Thanks for the help.

  1. ~Create a container issue like #26326 to track gRPC and SignalR from the preview blogs.~ Use this container issue for all new gPPC and SignalR issues. 7 will be out soon and others will follow, so keep updating that.
  2. Typically a new feature needs to be added to an existing doc and rarely to a new doc. Do that first. In the pr, mention contributes to #123 (the tracking issue). Once that's merged, finish up of the issue by updating What's new in ASP.NET Core 7.0

Rick-Anderson avatar Aug 03 '22 03:08 Rick-Anderson

@Rick-Anderson, thanks that clears it up I think. You want me to update all existing gRPC and SignalR docs we have in this repo to v7.0 as it relates to new features covered in the 1-6 preview 7.0 blogs. Then as a last step update the What's new in ASP.NET Core 7.0. You were losing me on the scope what all I was updating in the line "After you update a gRPC or Signal doc". Thanks for help.

wadepickett avatar Aug 03 '22 03:08 wadepickett

Update to to reflect the new 7.0 features, I'm not asking you to update them for .NET 7. And it's not just 1-6, it's all the new features, even those that come out for RTW post the last preview.

Rick-Anderson avatar Aug 03 '22 04:08 Rick-Anderson

@Rick-Anderson, thanks, just reflect the new feature information. Yes, and not just the 1-6 you listed, but the future ones for RTW. Thanks!

wadepickett avatar Aug 03 '22 04:08 wadepickett

Notes: (Draft, still adding info) gRPC:

  • [x] gRPC JSON Transcoding, Introduced in Preview 4.

    • [x] Update docs topics.: Verified we already have this feature covered from a number of PR's for gRPC JSON transcoding in ASP.NET Core gRPC apps. James feels a bigger summary might be eventually needed on annotating .proto but it is introduced for now in the existing gRPC JSON Transcoding doc. Discussed #26622.
    • [x] Update What's New

  • [x] gRPC JSON Transcoding OpenAPI: Covered in new topic: gRPC JSON transcoding documentation with Swagger / OpenAPI with PR #27053

    • [x] - [x] Update What's New PR #27331

  • [x] (No topic update needed) Transcoding performance improvements announced Preview 7. tracking issue #26760. Use .NET 7 Preview 7 as a starting guide

  • [x] gRPC JSON Transcoding: support for multi-segment parameters, Introduced Preview 6.

    • tracking issue: #26622
    • James doesn't want to pull the feature of multi-segment parameters into to docs, considering it unlikely to be used much. I will not include it in the docs, nor will I be including it in the What's New.

SignalR

  • [x] Client results in SignalR, Introduced in Preview 4 (completed with pr #26675)

  • [x] SignalR and the SignalR browser JavaScript client have been updated to support WebSockets over HTTP/2. Introduced in Preview 6. While I am there, I need to cover the larger change of HTTP/2 WebSocket support from #26366, so specifics for ASP.NET Core SignalR JavaScript client and ASP.NET Core SignalR with Blazor WebAssembly are within the larger context.

    • [x] Update docs topics: The topic and section to update WebSockets support in ASP.NET Core : SignalR. Brennan pointed out that only clients running in the browser have support for this as of 8/10/22. So only Javascript or SignalR .NET client with WASM. (done: PR: https://github.com/dotnet/AspNetCore.Docs/pull/26768 )
    • [x] (cancel) Update What's new: This is more related as a very sub-item to the larger feature of support in Kestral. So, I will not make a separate mention in the What's new for this one.

  • [x] Dependency injection for SignalR hub methods. Introduced in Preview 2.

    • [x] Update docs topic Use hubs in ASP.NET Core SignalR: Issue #26655 (Was already added in PR25746 April 27 by Brennan and is up to date.)
    • [x] Update What's new (already verified in there and link back is correct.)

  • [x] (Removing from list per Brennan, see below) SignalR client source generator. (Which adds support for strongly-typed clients and returning results from client invocations). Introduced in Preview 1.

wadepickett avatar Aug 04 '22 00:08 wadepickett

Don't add anything about the source generator.

BrennanConroy avatar Aug 08 '22 15:08 BrennanConroy

https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-dotnet-7-rc-1/#experimental-openapi-support-for-grpc-json-transcoding

Rick-Anderson avatar Oct 19 '22 19:10 Rick-Anderson

@Rick-Anderson, I thought we had that covered already in the recent https://learn.microsoft.com/en-us/aspnet/core/grpc/json-transcoding-openapi?view=aspnetcore-7.0&source=docs. Is there some part of it you think is missing? Could you provide more information about what you are communicating with the link?

wadepickett avatar Oct 19 '22 20:10 wadepickett

@Rick-Anderson, I thought we had that covered already in the recent https://learn.microsoft.com/en-us/aspnet/core/grpc/json-transcoding-openapi?view=aspnetcore-7.0&source=docs. Is there some part of it you think is missing? Could you provide more information about what you are communicating with the link?

How would anyone know that? See #26326 which shows each release where you can track the PR where each feature is addressed. This issue doesn't have RC1.

Rick-Anderson avatar Oct 19 '22 21:10 Rick-Anderson

Got it, what you were intending to communicate with the link was to make sure I have it accounted for in this tracking issue. Thanks, that makes sense and is helpful. You are right, I should have noted RC-1 even though the issue was already taken care of.

wadepickett avatar Oct 19 '22 21:10 wadepickett

A couple of gRPC features that were added in grpc-dotnet should be highlighted.

PR: https://github.com/dotnet/AspNetCore.Docs/pull/27454

JamesNK avatar Nov 01 '22 12:11 JamesNK

No tasks left. Fixed with PR's #26675, #26679, #27331, #27454

wadepickett avatar Nov 09 '22 20:11 wadepickett