react-native-ble-plx
react-native-ble-plx copied to clipboard
dotintent
Add two instructions in README to prevent Android users from running into #248 and #730
Current Behavior
Users integrating this package supporting Android SDK >= 23 might run into #730 and will run into #248.
New behavior
Users integrating this package supporting Android SDK >= 23 have all information provided by README to get started without hiccups.
Details
Even thought the issues (#248 & #730) are closed since instructions are given inside the issues, having the information provided in the README will prevent users from having to dig through the internet to resolve them once encountered.
Breaking changes
None
Sorry, still meaning to get around to fixing the Readme edits
On Fri, Jan 28, 2022, 11:54 mciechanowicz @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/dotintent/react-native-ble-plx/pull/940#pullrequestreview-865979108, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2D5B5QJ7ZA7GGMFP4SDLUYJYVJANCNFSM5KY6CEXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
Can we get this PR merged. I came across this exact issue when integrating and it would have been really helpful to have these doc changes in the readme. I'm sure other are wasting time on this too.
Same here, very useful info, please merge :)
Pinging @mciechanowicz @srgtuszy @gegitor in the hope we can get this merged.
