dotenv-linter icon indicating copy to clipboard operation
dotenv-linter copied to clipboard

feat: add support for stdin and stdin-filename options

Open SirSam21 opened this issue 1 year ago • 3 comments

Closes #803

✔ Checklist:

  • [ ] Commit messages have been written in Conventional Commits format;
  • [x] Tests for the changes have been added (for bug fixes / features);
  • [ ] Docs have been added / updated on the dotenv-linter.github.io (for bug fixes / features).

SirSam21 avatar Sep 02 '24 03:09 SirSam21

I wanted to add that some of this code may look awkward because I tried to make stdin fit into the project structure that focuses on traversing directories and reading files directly. I'm hoping to get some input from others on how this might be addressed.

SirSam21 avatar Sep 02 '24 03:09 SirSam21

I removed --stdin-filename and fixed the tests I made. For the tests I pretty much just had to add the with_default_args() to avoid the update check during testing.

SirSam21 avatar Sep 08 '24 07:09 SirSam21

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:x: Patch coverage is 97.05882% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 99.06%. Comparing base (5b6de3a) to head (9f03ec3). :warning: Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
dotenv-linter/src/lib.rs 95.45% 2 Missing :warning:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
- Coverage   99.15%   99.06%   -0.09%     
==========================================
  Files          46       48       +2     
  Lines        2834     3205     +371     
==========================================
+ Hits         2810     3175     +365     
- Misses         24       30       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 08 '24 14:09 codecov-commenter