graphql-code-generator
graphql-code-generator copied to clipboard
dotansimha
remove skipDocumentsValidation from near-operation-file
This field is no longer needed as the proper fix was introduced in 7c60e5accb.
Description
In 2019 #2143 lead to 1559ab6820. This resulted in typechecking being disabled for near-operation-file presets. Since that change the ability to toggle this setting was introduced in: 7c60e5accb. Running the same tests from #2143 it should now be possible to remove the default disable of typechecking for near-operation-file preset. Typechecking is important and should be enabled by default.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Related #8221
Type of change
Please delete options that are not relevant.
- [X] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- This has been tested using the following repo to run the tests here: https://github.com/klyve/graphql-codegen-preset-test
Test Environment:
- OS: macOS
- NodeJS: 16.16.0
- @graphql-codegen/near-operation-file-preset: 2.4.1 + change
- @graphql-codegen/cli: 2.11.5
- @graphql-codegen/introspection: 2.2.1
- @graphql-codegen/typescript: 2.7.3
- @graphql-codegen/typescript-operations: 2.5.3
- @graphql-codegen/typescript-react-apollo: 3.3.3
Checklist:
- [X] I have followed the CONTRIBUTING doc and the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] Any dependent changes have been merged and published in downstream modules
🦋 Changeset detected
Latest commit: 6bb5a777e3d53c2df6ba07ad562df5a630ad3d30
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @graphql-codegen/near-operation-file-preset | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
@klyve is attempting to deploy a commit to the The Guild Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| graphql-code-generator | ✅ Ready (Inspect) | Visit Preview | Aug 19, 2022 at 1:44PM (UTC) |
@klyve, thank you for your raising this concern!
I've pushed a more conservative alternative, let me know what you think 👀
I agree with the change you have pushed. It's a way more conservative fix to the problem, thanks 👍 Might want to re-add the test / enable the ability to change this through preset options?
@klyve, thank you for your raising this concern! I've pushed a more conservative alternative, let me know what you think 👀
I agree with the change you have pushed. It's a way more conservative fix to the problem, thanks 👍 Might want to re-add the test / enable the ability to change this through preset options?
I agree, we should restore the test and enable changing it through the presetOptions
Thanks
Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.
Community plugins:
@graphql-codegen/typescript-react-apollo@graphql-codegen/typescript-graphql-request@graphql-codegen/typescript-apollo-angular@graphql-codegen/typescript-apollo-client-helpers@graphql-codegen/typescript-react-query@graphql-codegen/typescript-urql@graphql-codegen/named-operations-object@graphql-codegen/urql-introspection@graphql-codegen/flow-resolvers@graphql-codegen/typescript-vue-apollo@graphql-codegen/typescript-rtk-query@graphql-codegen/flow-operations@graphql-codegen/typescript-msw@graphql-codegen/typescript-mongodb@graphql-codegen/typescript-type-graphql@graphql-codegen/jsdoc@graphql-codegen/typescript-vue-urql@graphql-codegen/kotlin@graphql-codegen/typescript-vue-apollo-smart-ops@graphql-codegen/java@graphql-codegen/c-sharp-operations@graphql-codegen/hasura-allow-list@graphql-codegen/typescript-stencil-apollo@graphql-codegen/relay-operation-optimizer@graphql-codegen/typescript-oclif@graphql-codegen/java-resolvers@graphql-codegen/java-apollo-android@graphql-codegen/flutter-freezed
Please move your PR by following these steps:
From your current PR branch:
- Fork the https://github.com/dotansimha/graphql-code-generator-community repository
- git remote add codegen-community <GIT_URL_OF_YOUR_COMMUNITY_REPO_FORK>
- git fetch codegen-community
- git push codegen-community
Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!
was merged https://github.com/dotansimha/graphql-code-generator-community/pull/383
