graphql-code-generator-community icon indicating copy to clipboard operation
graphql-code-generator-community copied to clipboard

fix(near-operation-file-preset): fragment generation without suffix

Open Laruxo opened this issue 1 year ago • 1 comments

Description

I found that all fragment types were generated with _ suffix in the imports even with omitOperationSuffix: false. However, in the generated usage of the type, this suffix did not exist (works correctly with omitOperationSuffix).

In the past, near-operation-file-preset used to work with the following versions:

    "@graphql-codegen/cli": "5.0.0",
    "@graphql-codegen/typescript": "4.0.9",
    "@graphql-codegen/typescript-operations": "4.0.1",

With this fix the preset also works with the latest versions.

Related https://github.com/dotansimha/graphql-code-generator-community/issues/812

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I created a local patch of this library and continue to use the preset with the latest versions of other packages.

Test Environment:

  • OS: macOS 15.1.1
  • @graphql-codegen/cli: 5.0.3
  • @graphql-codegen/typescript: 4.1.2
  • @graphql-codegen/typescript-operations: 4.4.0
  • NodeJS: v20.18.0

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Laruxo avatar Dec 16 '24 20:12 Laruxo

⚠️ No Changeset found

Latest commit: 70a4cff606237f53cb13158dfd62b065b09dfd05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 16 '24 20:12 changeset-bot[bot]