graphql-code-generator-community
graphql-code-generator-community copied to clipboard
fix(typescript-vue-urql): variable typing
Description
Generation template for vue urql query/subscription was changed in https://github.com/dotansimha/graphql-code-generator-community/pull/329.
That was necessary due to changes in urql-vue lib, which caused a number of regressions. Currently, all of them was fixed and finally released with [email protected]
This PR basically reverts https://github.com/dotansimha/graphql-code-generator-community/pull/329 and and fits [email protected] changes.
Related #328 Related #403 Related https://github.com/dotansimha/graphql-code-generator/issues/9421
Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
- Was built and used in live internal project
Test Environment:
- OS: MacOS
- @graphql-codegen/typescript-vue-urql:
- NodeJS: 20
Checklist:
- [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
Further comments
https://github.com/urql-graphql/urql/pull/3605
🦋 Changeset detected
Latest commit: 678c1ea00263ea870eed5846fdbbbc9047451ae3
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @graphql-codegen/typescript-vue-urql | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Not saying this isn't PR necessary, but in case people stumble upon this PR, we recommend TypedDocumentNode-based tools to be used for deriving types for GraphQL operations, even with @urql/vue bindings, since those reliably and universally work and align with GraphQL patterns more nicely.
Specifically, we'd recommend, if GraphQL Code Generator should still be used for people to migrate to the client-preset (which uses the typed-document-node plugin) or to gql.tada, a separate project (which is also maintained by the urql core team)
Released @graphql-codegen/[email protected]