graphql-code-generator-community icon indicating copy to clipboard operation
graphql-code-generator-community copied to clipboard

feat(typescript-vue-urql): Allow reactive query input

Open tdebooij opened this issue 1 year ago • 2 comments

Description

Allows ref, reactive and computed as input for all query variables in the Urql composables.

Related #194

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [x] Updated existing test in urql.spec.ts

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

Further comments

I saw in other plugins use this.getExportPrefix() before the type definition, but since the vue-urql plugin visitor extends ClientSideBaseVisitor and not TsVisitor I was unsure how to proceed with this.

tdebooij avatar Mar 17 '24 21:03 tdebooij

⚠️ No Changeset found

Latest commit: ddac4995cbec119ebefdcce7dece4653ff3fa43d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 17 '24 21:03 changeset-bot[bot]

Can anyone take a look at this or help me in the right direction?

tdebooij avatar Apr 12 '24 07:04 tdebooij