graphql-code-generator-community icon indicating copy to clipboard operation
graphql-code-generator-community copied to clipboard

feat(typescript-graphql-request): add support for web-scoket client

Open lyubo opened this issue 2 years ago • 4 comments
trafficstars

Description

This PR adds typescript code generation for graphql-request's GraphQLWebSocketClient

Related #401

Type of change

Please delete options that are not relevant.

  • [X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I ran the yarn test command in the root of the graphql-code-generator-comminuty project to check that the functionality is not broken and everything works as expected.

Test Environment:

  • OS: MacOS
  • @graphql-codegen/typescript-graphql-request: 6.0.0
  • NodeJS: 18.17.1

Checklist:

  • [X] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

lyubo avatar Sep 14 '23 15:09 lyubo

⚠️ No Changeset found

Latest commit: e754fdbe2a842564819a3628703a7a207e700462

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 14 '23 15:09 changeset-bot[bot]

can you please add some tests

Yes, sure. Should I close this PR and make a new one with tests included?

lyubo avatar Oct 20 '23 16:10 lyubo

@lyubo you can just push tests to this PR

saihaj avatar Dec 18 '23 20:12 saihaj

Any news bout merging this? Really need a websocket client for subscriptions.

rsodre avatar Apr 29 '24 18:04 rsodre