graphql-code-generator-community icon indicating copy to clipboard operation
graphql-code-generator-community copied to clipboard

fix(typescript-urql-graphcache): improve typing

Open dargmuesli opened this issue 6 months ago • 2 comments

Description

Linting typescript-urql-graphcache's output file showed some room for improvement, so this PR resolves a duplicate import source and improves typing for "empty object".

Related # (issue)

https://github.com/dotansimha/graphql-code-generator-community/issues/1109 https://github.com/dotansimha/graphql-code-generator-community/issues/445

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

n/a

How Has This Been Tested?

  • [x] existing test snapshots have been updated

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

n/a

dargmuesli avatar May 23 '25 05:05 dargmuesli

🦋 Changeset detected

Latest commit: 30ee6e8509b07a79e1ad2317b1499426057a93ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-urql-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 23 '25 05:05 changeset-bot[bot]

let me kindly cc last editors of the changed line @beerose and @JoviDeCroock for review if time allows

dargmuesli avatar May 23 '25 05:05 dargmuesli