graphjin icon indicating copy to clipboard operation
graphjin copied to clipboard

Submodules are not tagged correctly.

Open HappyHacker123 opened this issue 1 year ago • 8 comments

What version of GraphJin are you using? graphjin version

v3.0.1

Have you tried reproducing the issue with the latest release?

Yes.

Steps to reproduce the issue.

Run go get github.com/dosco/graphjin/core/v3 v3.0.31

Expected behaviour and actual result.

It seems that current graphjin has mutliple submodules with their own go.mod, for example, core and cmd. However, it seems that the submodules are not properly tagged. According to Go Modules standard , submodule should be tagged like relative-path-to-root/vX.X.X. At now, when trying to import package github.com/dosco/graphjin/core, downstream project would have to depend on pseudo-version of it and cannot get a valid tag version.

	github.com/dosco/graphjin/core/v3 v3.0.0-20240713020306-3fb8338c363e 

To address this, i think it's better to tag submodules properly according to Go standard, for example, releasing a tag `core/v3.0.31``, so that downstream project can use tag version to import the submodule in go.mod.

HappyHacker123 avatar Sep 03 '24 13:09 HappyHacker123