graphjin icon indicating copy to clipboard operation
graphjin copied to clipboard

Aggregation functions readability in introspection

Open frederikhors opened this issue 5 years ago • 1 comments

I think it's a bit ugly to see such a list in the instrospections:

account_id
avg_account_id
avg_id
avg_score
count_account_id
count_id
count_score
created_at
id
max_account_id
max_id
max_score
min_account_id
min_id
min_score
score
stddev_account_id
stddev_id
stddev_pop_account_id
stddev_pop_id
stddev_pop_score
stddev_samp_account_id
stddev_samp_id
stddev_samp_score
stddev_score
updated_at
var_pop_account_id
var_pop_id
var_pop_score
var_samp_account_id
var_samp_id
var_samp_score
variance_account_id
variance_id
variance_score

It would be much more readable in my opinion to have a list like this:

account_id
account_id_avg
account_id_count
account_id_max
account_id_min
account_id_stddev
account_id_stddev_pop
account_id_stddev_samp
account_id_var_pop
account_id_var_samp
account_id_variance
created_at
id
id_avg
id_count
id_max
id_min
id_stddev
id_stddev_pop
id_stddev_samp
id_var_pop
id_var_samp
id_variance
score
score_avg
score_count
score_max
score_min
score_stddev
score_stddev_pop
score_stddev_samp
score_var_pop
score_var_samp
score_variance
updated_at

What do you think, @dosco?

frederikhors avatar Jul 04 '20 16:07 frederikhors

I don't know what the right thing here is, won't changing the format of functions make it harder to auto-complete. I was thinking about this like a function call count(id) translates to count_id

dosco avatar Jul 05 '20 17:07 dosco