nyaplot icon indicating copy to clipboard operation
nyaplot copied to clipboard

Package JS libraries in nyaplot and don't rely on external CDN

Open v0dro opened this issue 9 years ago • 3 comments

This elagans link: (https://cdn.rawgit.com/domitry/d3-downloadable/master/d3-downloadable","THREE":"https://cdnjs.cloudflare.com/ajax/libs/three.js/r66/three.min) is not being downloaded via the CDN.

I think including it with the repo would solve the problem.

v0dro avatar Jun 06 '16 14:06 v0dro

Inlining JS file can fix this issue, I think.

I want to introduce a feature like load_notebook in bokeh. It can allow us to specify where assets are loaded from. At least I want to select inline or cdn at nyaplot initialization time, and I prefer the default is inline (bokeh's default is also inline).

But it needs to change nyaplot initialization protocol. While we just need to do require 'nyaplot'currently, introducing bokeh feature requires explicit initialization.

I think this modification is acceptable. How do you think about it?

mrkn avatar Jun 12 '16 12:06 mrkn

Sure. We can have some reliable default setting that works most of the time and also allow flexibility to choose sources with the load_notebook initialization.

v0dro avatar Jun 12 '16 15:06 v0dro

I've submit a pull-request https://github.com/domitry/nyaplot/pull/80

mrkn avatar Jun 22 '16 05:06 mrkn