go-tools icon indicating copy to clipboard operation
go-tools copied to clipboard

Published 20 hours ago • verified publisher icon dominikh

Website: update docsy theme

Open deining opened this issue 3 years ago • 5 comments

The website uses the docsy theme. This PR converts this theme from git submodule to hugo module. It also brings the theme to latest released version v0,.2.0.

deining avatar May 02 '22 08:05 deining

Thanks; I'll take another look at this in a couple days.

dominikh avatar May 07 '22 21:05 dominikh

Looking at the open issue on Hugo, I don't expect this to get fixed on their end any time soon. And while we could use -modfile for our non-Hugo Go code, I'm not willing to work around Hugo's abuse of the go.mod file. It'll be confusing for anyone who wants to work on the website module and doesn't know they have to use -modfile.

It would've been nice to get rid of git submodules, but this isn't the way. Feel free to update this PR to just bump the submodule to v0.2.0 of docsy and remove our unnecessary modifications; or close the PR if you feel it's not worth your time.

image

dominikh avatar May 16 '22 14:05 dominikh

@deining are you still working on this?

KarthikNayak avatar Jul 03 '22 17:07 KarthikNayak

@deining are you still working on this?

Please keep that issue open. I hope to find time soon to update the @docsy@ submodule only.

deining avatar Jul 04 '22 03:07 deining

I updated this PR to just bump the theme submodule to latest docsy version and removed your modifications that are not needed any more after this update.

deining avatar Jul 04 '22 09:07 deining

Merged and published, thanks.

dominikh avatar Jan 19 '23 12:01 dominikh