Swashbuckle.AspNetCore icon indicating copy to clipboard operation
Swashbuckle.AspNetCore copied to clipboard

Drop .NET 6

Open martincostello opened this issue 1 year ago • 3 comments

Drop support for .NET 6.

Resolves #3087.

Leaving in draft for now - it's best to ship after a period of stability where we've fixed any known regressions caused by v7.

martincostello avatar Nov 27 '24 12:11 martincostello

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.56%. Comparing base (730b315) to head (d549578).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          77       77           
  Lines        3224     3224           
  Branches      559      559           
=======================================
  Hits         2694     2694           
  Misses        530      530           
Flag Coverage Δ
Linux 83.56% <ø> (ø)
Windows 83.56% <ø> (ø)
macOS 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 27 '24 12:11 codecov-commenter

Please remove all #if NET6_0_OR_GREATER and #if NET7_0_OR_GREATER.

And if these IF statements have ELSE, update check to #if NET8_0_OR_GREATER. <----- EDIT: Umm, no, this is Swashbuckle.AspNetCore, not NSwag :D - we are not supporting .NET Framework

image

Saibamen avatar Nov 28 '24 00:11 Saibamen

No, that's unnecessary code churn that makes no difference just changing the version numbers.

The elses may be removable in some cases, but only for projects that don't target netstandard2.0.

martincostello avatar Nov 28 '24 07:11 martincostello