dokku-postgres icon indicating copy to clipboard operation
dokku-postgres copied to clipboard

Customizing volume path

Open whollacsek opened this issue 1 year ago • 3 comments

Hi @josegonzalez quick question, will it ever be possible to change the right hand side of the volume mount point? Some postgres images such as this one https://hub.docker.com/r/bitnami/postgresql uses /bitnami/postgresql

https://github.com/dokku/dokku-postgres/blob/29057e00a251df2eb167c68279404d758cc55be9/functions#L90

whollacsek avatar Sep 27 '24 05:09 whollacsek

Not a feature I've ever cared to build but maybe?

Do we have a "set" subcommand yet? Would maybe make this easier...

josegonzalez avatar Sep 27 '24 05:09 josegonzalez

I see thanks for the prompt response! You can leave this issue open if you deem it a potential feature

whollacsek avatar Sep 28 '24 03:09 whollacsek

Hello, just a random comment in case this helps someone. TLDR: supporting bitnami/postgres will be more complicated than I expected!

I was looking into using the bitnanmi/postgres image and was mostly able to update this plugin to allow configuring the mount path. However, specifically for bitnami/postgres, I ran into issues setting up SSL. This plugin currently enables SSL via sed, but bitnami/postgres expects this to be handled via ENV vars. It feels a little awkward to me to update this plugin to handle the two styles of SSL setup, especially since the plugin wouldn't know which method to choose. (As someone new to this codebase, I think it would be too large of a change for me to implement!)

I'm sure there's some value in being able to customize the volume path, but this won't be enough to support bitnami/postgres.

zachahn avatar May 30 '25 02:05 zachahn