dojo icon indicating copy to clipboard operation
dojo copied to clipboard

ci: Github Action for `cargo-udeps` failed

Open github-actions[bot] opened this issue 1 year ago • 4 comments
trafficstars

cargo-udeps failed: https://github.com/dojoengine/dojo/actions/runs/10549011382 Reference: branch refs/heads/main (commit 194438922a028dac6bf40533ce139dd742809902).

github-actions[bot] avatar Aug 25 '24 18:08 github-actions[bot]

Please can I be assigned to this issue?

ShantelPeters avatar Aug 26 '24 02:08 ShantelPeters

can i work on this?

ScottyDavies avatar Aug 26 '24 16:08 ScottyDavies

Hi @glihm William here from 🇨🇷 and part of the Dojo Coding Community

Quick question, Do you really think that was a false-positive as mentioned in the error? (just a matter of adding package.metadata.cargo-udeps.ignore in Cargo.toml)

Or did something really happen with the dependencies and has to be fixed/cleaned up this week?

image

wugalde19 avatar Aug 27 '24 04:08 wugalde19

@wugalde19 it would be hard to tell just from looking at the error, from my experience udeps dont have false positives and most likely we have some dependencies where they are not required

itzlambda avatar Sep 02 '24 13:09 itzlambda