test: add failing test on chain id conversion

[greged93]

trafficstars

Description

This PR is made in other to provide a failing example for issue https://github.com/dojoengine/dojo/issues/1595.

Related issue

https://github.com/dojoengine/dojo/issues/1595

Tests

• [x] Yes
• [ ] No, because they aren't needed
• [ ] No, because I need help

Added to documentation?

• [ ] README.md
• [ ] Dojo Book
• [x] No documentation needed

Checklist

• [x] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
• [x] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
• [x] I've commented my code
• [ ] I've requested a review after addressing the comments

Summary by CodeRabbit

• New Features

  • Introduced a new test for validating chain ID conversions, focusing on edge cases with invalid UTF-8 representations.

• Bug Fixes

  • Enhanced test coverage for chain ID conversion logic to capture potential issues, improving overall system reliability.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 70.27%. Comparing base (f1c5214) to head (df8464f).

Files	Patch %	Lines
...na/executor/src/implementation/blockifier/utils.rs	0.00%	14 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
- Coverage   70.29%   70.27%   -0.02%     
==========================================
  Files         342      342              
  Lines       45094    45108      +14     
==========================================
+ Hits        31698    31699       +1     
- Misses      13396    13409      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Eikix]

What is the status of this @glihm @greged93?

[kariy]

@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now

[Eikix]

@Eikix im workin on this rn, i've identified why it still failing, just gonna add some more test now

<3333 okk thx

[kariy]

@Eikix @greged93 ok this time it should definitely work as expected

[kariy]

@Eikix @greged93 i took the liberty to rebase it to v1.0.0-alpha.16 to ease the independent testing because there are some breaking changes in the genesis json file format after the alpha.16.

[glihm]

Will close since it's blockifier dependent, the issue will remain open. 👍