dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Events annotated by `#[dojo::event]` are not annotated as event in ABI

Open itzlambda opened this issue 1 year ago • 1 comments
trafficstars

Describe the bug Sozo events subcommand uses the ABI to parse the events, but since custom dojo events are not annotated sozo currently cannot parse them.

Once this issue is fixed we need to update sozo accordingly so it can parse those events. Also note in dojo events we add the system address which emitted it as the key in event ourself, that also needs to be considered.

itzlambda avatar Jul 30 '24 08:07 itzlambda

To solve this, we should add a "phantom" method on models that are dojo::event to ensure we have a way to determine that from the ABI.

glihm avatar Jul 30 '24 16:07 glihm

Events are now emitted differently than before, with their own ABI file, and they are not starknet event anymore. 👍

glihm avatar Nov 11 '24 20:11 glihm