dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Katana and ArgentX wallet

Open Matth26 opened this issue 1 year ago • 1 comments

Description

This PR includes the following fixes to support connecting an ArgentX wallet with the local Katana environment:

  • Path Update: Corrected a wrong path in the declare-argent-account.sh script.
  • CORS Headers: Added allowed headers to the CORS layer to avoid a CORS policy error when the ArgentX wallet tries to initiate a transaction.

Related issue

This is required to run the starknet-react-app on katana: https://github.com/dojoengine/dojo.js/pull/203

Tests

  • [ ] Yes
  • [x] No, because they aren't needed
  • [ ] No, because I need help

Added to documentation?

  • [ ] README.md
  • [ ] Dojo Book
  • [x] No documentation needed

Checklist

  • [ ] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • [x] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • [x] I've commented my code
  • [ ] I've requested a review after addressing the comments

Matth26 avatar May 14 '24 14:05 Matth26

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.96%. Comparing base (a095ccf) to head (412c636). Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
- Coverage   69.80%   67.96%   -1.84%     
==========================================
  Files         313      318       +5     
  Lines       35526    37093    +1567     
==========================================
+ Hits        24800    25212     +412     
- Misses      10726    11881    +1155     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 14 '24 14:05 codecov[bot]