dojo icon indicating copy to clipboard operation
dojo copied to clipboard

[sozo] change manifests files name for folders

Open glihm opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. Currently, the manifests files were generated with fully_qualified_named.toml/json. But ideally, we want a folder to represent the path of the fully qualified name.

Describe the solution you'd like For example:

dojo_examples::actions::actions.toml

// should be
dojo_examples/actions/actions.toml

Additional context Here's where we replace the ::: https://github.com/dojoengine/dojo/blob/f0637f928470217fccd60fe15b1b9c6fefd5c984/crates/dojo-world/src/manifest/mod.rs#L99. We should create a path instead.

Also, we sorted the entries to ensure we don't have manifests diffs just based on the order: https://github.com/dojoengine/dojo/blob/f0637f928470217fccd60fe15b1b9c6fefd5c984/crates/dojo-world/src/manifest/mod.rs#L508

We should use a SortedMap to keep the manifests to ensure we always output the manifests in the same order into the deployment to avoid diffs only for orders.

glihm avatar Apr 08 '24 14:04 glihm

@lambda-0x could you take this one? :)

glihm avatar Apr 08 '24 14:04 glihm

This will be reworked during namespaces implementation to not be dependent on file structure for the manifests files.

glihm avatar Jun 19 '24 21:06 glihm