dojo
dojo copied to clipboard
Refactor torii grpc queries
The gRPC entities endpoint supports three query clauses - HashedKeysClause, KeysClause, and MemberClause. Previously, the MemberClause could only filter one member of a single model. This PR renames it to ModelsClause and supports filtering multiple model members.
Example:
"query": {
"clause": {
"models": {
"members": [
{
"member": "remaining",
"model": "Moves",
"operator": "GTE",
"value": {
"int_value": 0
}
},
{
"member": "player",
"model": "Position",
"operator": "EQ",
"value": {
"byte_value": "BhYoltHXqyBMfMrG3V+Onnwl7NWuT8tK0y5XeGu0bgM="
}
}
],
"operator": "AND"
}
},
"limit": 5,
"offset": 0
}
Codecov Report
Attention: Patch coverage is 3.62538% with 319 lines in your changes are missing coverage. Please review.
Project coverage is 69.56%. Comparing base (
cf095de) to head (65438cb). Report is 29 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
+ Coverage 69.09% 69.56% +0.46%
==========================================
Files 265 266 +1
Lines 26859 27214 +355
==========================================
+ Hits 18559 18932 +373
+ Misses 8300 8282 -18
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Will be tracked by #1613 and some work was already done. 👍