dojo icon indicating copy to clipboard operation
dojo copied to clipboard

Refactor torii grpc queries

Open broody opened this issue 1 year ago • 1 comments
trafficstars

The gRPC entities endpoint supports three query clauses - HashedKeysClause, KeysClause, and MemberClause. Previously, the MemberClause could only filter one member of a single model. This PR renames it to ModelsClause and supports filtering multiple model members.

Example:

  "query": {
      "clause": {
          "models": {
              "members": [
                  {
                      "member": "remaining",
                      "model": "Moves",
                      "operator": "GTE",
                      "value": {
                          "int_value": 0
                      }
                  },
                  {
                        "member": "player",
                        "model": "Position",
                        "operator": "EQ",
                        "value": {
                            "byte_value": "BhYoltHXqyBMfMrG3V+Onnwl7NWuT8tK0y5XeGu0bgM="
                        }
                    }
              ],
              "operator": "AND"
          }
      },
      "limit": 5,
      "offset": 0
  }

broody avatar Mar 08 '24 21:03 broody

Codecov Report

Attention: Patch coverage is 3.62538% with 319 lines in your changes are missing coverage. Please review.

Project coverage is 69.56%. Comparing base (cf095de) to head (65438cb). Report is 29 commits behind head on main.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 0.00% 220 Missing :warning:
crates/torii/grpc/src/types/mod.rs 0.00% 55 Missing :warning:
crates/torii/core/src/model.rs 26.92% 19 Missing :warning:
crates/torii/client/src/client/mod.rs 0.00% 12 Missing :warning:
crates/torii/grpc/src/client.rs 0.00% 4 Missing :warning:
.../torii/grpc/src/server/subscriptions/model_diff.rs 0.00% 4 Missing :warning:
...ates/torii/grpc/src/server/subscriptions/entity.rs 0.00% 3 Missing :warning:
crates/torii/client/src/client/subscription.rs 83.33% 1 Missing :warning:
crates/torii/core/src/cache.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   69.09%   69.56%   +0.46%     
==========================================
  Files         265      266       +1     
  Lines       26859    27214     +355     
==========================================
+ Hits        18559    18932     +373     
+ Misses       8300     8282      -18     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 08 '24 21:03 codecov[bot]

Will be tracked by #1613 and some work was already done. 👍

glihm avatar Jun 27 '24 03:06 glihm