book icon indicating copy to clipboard operation
book copied to clipboard

Document new address parsing for arguments

Open glihm opened this issue 1 year ago • 3 comments

This PR https://github.com/dojoengine/dojo/pull/1434 is introducing a new way to pass a socket address to a service.

:u16 -> will be considered as a port, and localhost is automatically added. hostname -> will only consider the hostname. hostname:port -> fully qualified address.

glihm avatar Jan 13 '24 19:01 glihm

Is this issue still up, i'd like to attempt it

faytey avatar Apr 30 '24 10:04 faytey

have assigned!

ponderingdemocritus avatar Apr 30 '24 10:04 ponderingdemocritus

Please i have a couple of questions @ponderingdemocritus firstly where exactly am I to make these changes, secondly is this the correct parsing reference to use #[arg(long, value_name = "SOCKET", default_value = ":5050", value_parser = parse_socket_address)] rpc: SocketAddr,

faytey avatar May 02 '24 15:05 faytey