kube-no-trouble
kube-no-trouble copied to clipboard
feat: Add prometheus printer
Adding a new "printer" (reporter, exporter?) to push Kubent output to Prometheus via Pushgateway. Any feedback is appreciated.
Relates to #302 and the discussion in #218
New Configuration
Flags
-o prometheusis now an allowed option
Environment Variables
PUSHGATEWAY_URL: The URL of the Prometheus Pushgateway.PUSHGATEWAY_JOB: The job to collect metrics under.
If -o prometheus is set, then both of these variables are required to be set.
Remaining Questions
- Maybe need to expand on the configuration abilities for printers...Is environment variables the right approach or should printers be able to accept custom config/define their own flags?
Remaining Work
- [ ] Add Pushgateway auth options
- [ ] Add unit testing
Not to tell you that you shouldn't do this, but you might consider https://github.com/isugimpy/kubent_exporter/ as an alternative to this. Having a publisher built in would be pretty cool though.
This PR has not seen any activity in last 60 days and has been marked as stale
Hi @atzawada , I think we can support this. Not sure about adding all those env variables, we handle those in config.go. Happy to add the printer, but pushing the messages should probably be handled by another tool.
If you rebase this and add some tests I'll happily merge it.
This PR has not seen any activity in last 60 days and has been marked as stale
This PR was closed because it has been stalled for 90 days with no activity.