docusign-esign-php-client icon indicating copy to clipboard operation
docusign-esign-php-client copied to clipboard

Fix PHP 8.4 deprecations

Open v-noskov opened this issue 9 months ago • 6 comments

Implicitly marking function/method parameters as nullable is deprecated in PHP 8.4. Please, fix deprecation at least in these classes:

docusign/esign-client/src/Client/ApiClient.php:91
DocuSign\eSign\Client\ApiClient::__construct(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead
DocuSign\eSign\Client\ApiClient::__construct(): Implicitly marking parameter $oAuth as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Configuration.php:185
DocuSign\eSign\Configuration::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/EnvelopeDefinition.php:626
DocuSign\eSign\Model\EnvelopeDefinition::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/EnvelopeSummary.php:216
DocuSign\eSign\Model\EnvelopeSummary::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/EnvelopeTemplateResults.php:216
DocuSign\eSign\Model\EnvelopeTemplateResults::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/RecipientViewRequest.php:261
DocuSign\eSign\Model\RecipientViewRequest::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/Tabs.php:371
DocuSign\eSign\Model\Tabs::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/TemplateRole.php:256
DocuSign\eSign\Model\TemplateRole::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/Text.php:776
DocuSign\eSign\Model\Text::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead

docusign/esign-client/src/Model/ViewUrl.php:180
DocuSign\eSign\Model\ViewUrl::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead


v-noskov avatar Feb 19 '25 16:02 v-noskov

I'm adding a full list of deprecations from docusign-esign-php-client v.8.0.0. You can get the same list using PHP 8.4 linter php -l

docusign_deprecations.txt

v-noskov avatar Apr 16 '25 16:04 v-noskov

Same issue referred in #238.

We are aware and working on it internally.

AliceGoglione-DS avatar May 12 '25 20:05 AliceGoglione-DS

We have added this as a backlog and will be picking this up considering this deprecation is a warning for now and will be fixed soon.

prudhvik-docusign avatar May 19 '25 05:05 prudhvik-docusign

@prudhvik-docusign any updates? :)

khaperets avatar Sep 26 '25 11:09 khaperets

The changes are done. It will be released as part of next sdk release cycle

prudhvik-docusign avatar Sep 26 '25 11:09 prudhvik-docusign

Thanks!

khaperets avatar Sep 26 '25 11:09 khaperets