documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Our implementation of doctrine library

Open anthony-redFox opened this issue 8 years ago • 2 comments

I think we need to create new repository for doctrine with issues and pull requests. I prepare take a doctrine version 1.5 (it is important because version 1.5 contains a MIT license and then remove a closure-compiler has Apache 2.0 License) otherwise we need to change License, but I don't want.

Edit: may be better push in to current repository ...

Also we have to change jsDoc as we need. Also it is dependence of issue #857 for example.

Another topic, if we want to change jsDoc also need good documentation what kind of tags we support or which difference with jsdoc. How to check with eslint and etc. @tmcw thoughts?

anthony-redFox avatar Aug 09 '17 17:08 anthony-redFox

Hmm, so I volunteered to help review PRS in this thread but was never granted the ability to. Hopefully I can get rights on that project, otherwise we'll need to fork. I don't like forking, but doctrine is also becoming a real bottleneck for this project.

tmcw avatar Aug 09 '17 22:08 tmcw

I now have the ability to review & merge PRs on doctrine, and will try to get through the queue.

tmcw avatar Aug 10 '17 21:08 tmcw