Fix matching lazy collections with enums criteria

[kira0269]

trafficstars

Fix issue #11481

I identified some duplicated code between the BasicEntityPersister and the ManyToManyPersister, like the method expandCriteriaParameters. Because I don't want to create side effects, I just factorized two methods : getValues and getIndividualValue into a trait.

Thanks for your review !

[derrabus]

Please find a meaningful title for your PR. We use the titles in our automatically composed change log.

[kira0269]

Hello @derrabus Could you review this PR please ? Also, the change you requested was applied on the first commit, it's still active despite the fact the file has been updated. Thank you 😄

[kira0269]

Up @derrabus . This PR is still stuck because of your ghost request change :cry:

[kira0269]

Hi,

I've got these issues from Psalm:

Error: src/Persisters/Entity/BasicEntityPersister.php:0:0: UnusedBaselineEntry: Baseline for issue "LessSpecificReturnStatement" has 3 extra entries. (see https://psalm.dev/316)
Error: src/Persisters/Entity/BasicEntityPersister.php:0:0: UnusedBaselineEntry: Baseline for issue "MoreSpecificReturnType" has 3 extra entries. (see https://psalm.dev/316)

And I don't understand what it means... I don't know how to fix those "issues".

Thanks for your help.

[SenseException]

Your changes seem to have removed code with psalm issues that is still ignored in the psalm baseline and don't need to be anymore. If you find the affected lines in the XML for BasicEntityPersister class and remove them, then the UnusedBaselineEntrys should be gone. Some of the ignored BasicEntityPersister issues could still be valid.

[kira0269]

Hi @derrabus

I don't know why, but the merging is blocked because of a change you requested on one of the commits of this branch. I applied the change, but github does not detect it. So could you remove your requested change please ?

Thanks a lot.

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want to continue working on it, please leave a comment.

[kira0269]

@beberlei @derrabus is there any other change you want me to apply on this PR ? Or is it ok ?

[mpdude]

To me, this looks like a bugfix which should go into 2.20.x?

[mpdude]

Similar approach in #11895, which also fixes in and notIn expression handling on many-to-many collections.

[kira0269]

PR #11895 fixing more issues. I close this one since it becomes obsolete.